search

stan-dev / projpred

Projection predictive variable selection
https://mc-stan.org/projpred/
Other
109 stars 25 forks source link

WISH: future_plan = NULL to support currently set future backend plan #396

Closed HenrikBengtsson closed 1 year ago

HenrikBengtsson commented 1 year ago

Hello. I see that you use:

https://github.com/stan-dev/projpred/blob/d6d9744b7ee84b9c14cffb846fc057195588f026/tests/testthat/test_parallel.R#L13-L21

This will not support any of the other future backends that currently exists (e.g. running across multiple machines via the cluster backend), or the ones that are under development right now or will be in the future (pun not intended).

I'd like to suggest that you make it possible to use whatever future backend that is already active, e.g. via future_plan = NULL or future_plan = "*".

fweber144 commented 1 year ago

Hi, thank you for this comment. But file projpred/tests/testthat/test_parallel.R only belongs to the tests; this is not intended to be general code. Your comment sounds like it referred to something inside a function. Or did I get this wrong?

HenrikBengtsson commented 1 year ago

Oh my, I missed it was a test script. So, yeah, ignore my comment/request. I came to this while troubleshooting a reverse dependency issue with doFuture.

fweber144 commented 1 year ago

No problem; thanks for watching out for reverse dependencies! And I might consider using some of your ideas from #397 even in the tests.