search

stan-dev / rstan

RStan, the R interface to Stan
https://mc-stan.org
1.02k stars 264 forks source link

Backport stanc3 bugfix for ternary ops with expressions #1035

Closed andrjohns closed 1 year ago

andrjohns commented 1 year ago

@hsbadr

This PR updates the stanc.js file to backport the bugfix from https://github.com/stan-dev/stanc3/pull/977 for handling ternary operations with Eigen expressions. This will be needed for the multinma package.

I used the same stanc3 branch previously used for backporting stanc3 patches in #988

hsbadr commented 1 year ago

@andrjohns I'll need a release out of this to ship the JS in RStan.

hsbadr commented 1 year ago

You may test it with the latest version of RStan v2.26.

andrjohns commented 1 year ago

No rush on shipping a new version just yet, I'm still working through other revdep failures for rstan 2.26 so there might be other patches still to come