226 cran checks

[andrjohns]

@bgoodri This PR resolves all CRAN NOTEs for the 2.26 StanHeaders branch.

The changes are:

• Removed static linking of the TBB (gave compiled code warnings)
• Changed to C++17 standard
• Changed citEntry() to bibentry()
• Fixed stanFunction not using package cxxflags

I've run R CMD CHECK and the revdep checks under Windows, MacOS, and linux. The only failures were the four previously mentioned packages:

• beanz
• dfpk
• idem
• visit

The check and reverse-depency results for all platforms are here: 226-check.zip

If you could merge and submit to CRAN, that would be great, otherwise let me know if there is more that you need

[bgoodri]

Thanks. This looks good, but can you remind me the implications of static vs. dynamic linking of TBB?

[andrjohns]

It was initially done to remove the need for downstream packages to additionally link to RcppParallel, but now they've all been updated so it's not really needed anymore

[bgoodri]

ok