stan-dev / rstan

RStan, the R interface to Stan
https://mc-stan.org
1.02k stars 264 forks source link

Fix LdFlags for new RcppParallel #1108

Closed jeroen closed 5 months ago

jeroen commented 5 months ago

Summary:

This copies a small tweak from RcppParallel to support cross compiling, see: https://github.com/RcppCore/RcppParallel/pull/208

Basically we check $TBB_LINK_LIB before checking $TBB_LIB which is needed when the runtime arch (TBB_LIB) is different from the one we are compiling for (TBB_LINK_LIB)

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Jeroen Ooms

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

andrjohns commented 5 months ago

Failures are unrelated to these changes, thanks again!

andrjohns commented 5 months ago

@bgoodri can you push your CRAN changes to the repo? That will resolve the current CI failures

bgoodri commented 5 months ago

Yes

andrjohns commented 5 months ago

@bgoodri quick reminder to please push your changes