Fix compilation under rstan 2.26

stan-dev / rstanarm

rstanarm R package for Bayesian applied regression modeling

https://mc-stan.org/rstanarm

GNU General Public License v3.0

388 stars 133 forks source link

Fix compilation under rstan 2.26 #510

Closed andrjohns closed 2 years ago

andrjohns commented 3 years ago

This PR adds Makevars flags needed to build rstanarm against the new 2.26 version of rstan

jgabry commented 3 years ago

Thanks @andrjohns! Will this now only work with 2.26 or will it still also work fine with older versions?

andrjohns commented 3 years ago

Looks like I missed a comment from @hsbadr on this! This flag should only be defined if the associated rstan version is >= 2.26. (that comment here). So this flag should be conditionally included using if (utils::packageVersion("rstan") >= 2.26). I'll have a look into fixing this up

jgabry commented 3 years ago

Ok great thanks!

andrjohns commented 2 years ago

Superseded by #574