search

stan-dev / rstanarm

rstanarm R package for Bayesian applied regression modeling
https://mc-stan.org/rstanarm
GNU General Public License v3.0
388 stars 133 forks source link

Remove custom C++ functions #558

Closed hsbadr closed 2 years ago

hsbadr commented 2 years ago

As discussed in #514 and #555, this PR removes all custom C++ functions and uses the replacement from Stan/Math. It also fixes building rstanarm with Stan v2.28.2, which requires a very minor patch for Math.

hsbadr commented 2 years ago

I'll look into the test failure tomorrow; it seems to be related to the following exception:

Exception: csr_matrix_times_vector: u/z (34) and v (35) must match in size
    (in '/model/eta_add_Zb.stan' at line 2; included from 'model_continuous' at line 150)
hsbadr commented 2 years ago

@bgoodri Before I spend time to fix the failed examples/tests (which refer to the checks in csr_matrix_times_vector), are you ok with the change of removing the custom C++ functions to improve backward/forward compatibility with Stan/Math?