search

stan-dev / rstantools

Tools for Developing R Packages Interfacing with Stan
https://mc-stan.org/rstantools
GNU General Public License v3.0
51 stars 21 forks source link

Fix packages with stanfunctions under rstan 2.33+ #117

Closed andrjohns closed 1 year ago

andrjohns commented 1 year ago

This PR resolves a similar issue as this cmdstanr PR: https://github.com/stan-dev/cmdstanr/pull/847

After 2.33 stanc3 will emit plain types for standalone functions instead of auto, so we no longer need to pre-process the hpp to do this ourselves.

This PR is needed for rstan 2.33 compatibility with packages like lgpr and rmdcev which export standalone functions during installation

andrjohns commented 10 months ago

@jgabry When you've got the time would you mind pushing a new release to CRAN? We'll need this change release for lgpr and rmdcev to build with the next rstan/StanHeaders

jgabry commented 10 months ago

Thanks! Yeah I can do a release soon. I just got back from traveling abroad for a few weeks and need to catch up on everything!

On Sat, Jan 13, 2024 at 5:24 AM Andrew Johnson @.***> wrote:

@jgabry https://github.com/jgabry When you've got the time would you mind pushing a new release to CRAN? We'll need this change release for lgpr and rmdcev to build with the next rstan/StanHeaders

— Reply to this email directly, view it on GitHub https://github.com/stan-dev/rstantools/pull/117#issuecomment-1890438460, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3PQQYKP2RINJM2QB6TQTLYOJ4JFAVCNFSM6AAAAAA4TEPDAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGQZTQNBWGA . You are receiving this because you were mentioned.Message ID: @.***>

andrjohns commented 10 months ago

No worries, there's no rush!

jgabry commented 10 months ago

I can get the ball rolling on this while catching up on other stuff. I'll start running reverse dependence checks.