stan-dev / shinystan

shinystan R package and ShinyStan GUI
https://mc-stan.org/shinystan
GNU General Public License v3.0
197 stars 51 forks source link

Fix #172: respect the `shiny.launch.browser`option #173

Closed danschrage closed 4 years ago

danschrage commented 4 years ago

See #172: If the user sets the shiny.launch.browser option to FALSE when running shinystan outside of RStudio, this change ensures that launch_shinystan() respects that. Otherwise, the default behavior (launch.browser=TRUE) is preserved.

codecov-io commented 4 years ago

Codecov Report

Merging #173 into master will decrease coverage by 4.26%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   97.09%   92.83%   -4.27%     
==========================================
  Files          10       10              
  Lines         896      795     -101     
==========================================
- Hits          870      738     -132     
- Misses         26       57      +31
Impacted Files Coverage Δ
R/launch_shinystan.R 35% <0%> (-3.1%) :arrow_down:
R/misc.R 80% <0%> (-20%) :arrow_down:
R/rhat_ess_monitor_fns.R 94.2% <0%> (-5.8%) :arrow_down:
R/shinystan-objects.R 93.12% <0%> (-5.73%) :arrow_down:
R/update_sso.R 93.54% <0%> (-3.83%) :arrow_down:
R/generate_quantity.R 97.22% <0%> (-2.78%) :arrow_down:
R/retrieve.R 97.33% <0%> (-1.37%) :arrow_down:
R/sso-metadata.R 100% <0%> (ø) :arrow_up:
R/drop_parameters.R 100% <0%> (ø) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28e3c5e...e8c9b48. Read the comment docs.

jgabry commented 4 years ago

@VeenDuco added this fix to the branch with the alpha version but I just noticed that we didn't merge this into master. i think we should include this fix in the current version on master too so merging now.