stan-dev / shinystan

shinystan R package and ShinyStan GUI
https://mc-stan.org/shinystan
GNU General Public License v3.0
197 stars 51 forks source link

diagnostics page doesn't load if `stan_used=FALSE`? #185

Open jgabry opened 4 years ago

jgabry commented 4 years ago

@VeenDuco something I noticed on the v3-alpha branch:

Part of the reason to allow sampler params and stuff to be specified when using the array method for as.shinystan() is to allow people running HMC/NUTS but not Stan to still get diagnostic info. However, if I use the "array" method for as.shinystan() and specify stan_used=FALSE then the "Diagnostics" page doesn't seem to load (it just stays blank). To verify this just change stan_used=FALSE in the new as.shinystan method for CmdStanMCMC objects that I added. So even though stan_algorithm="NUTS" and stan_method="sampling" and sampler_params are provided, it seems like stan_used=FALSE prevents it from loading diagnostics. Or is that just my computer?

VeenDuco commented 4 years ago

Hey I think you are right! The problem is in the diagnoseHompage.r file. I need to adjust the conditions to load the diagnostics pages. Will take a look at this asap.