search

stan-dev / stan-mode

Emacs mode for Stan.
GNU General Public License v3.0
72 stars 15 forks source link

v9.3.0 to support Stan 2.19.0 #57

Closed kaz-yos closed 5 years ago

kaz-yos commented 5 years ago

This is a minimalistic update to support Stan version 2.19.0 based on the 2.19.0 language definitions file in the stan-language-definitions repo (https://github.com/jrnold/stan-language-definitions), which I currently co-maintain with @jrnold.

CHANGES:

For a historical record, the first commit updates the keywords-list to 2.17.0, which was the version in the language definition submodule repo prior to my 2.19.0 update (https://github.com/jrnold/stan-language-definitions/commit/8fe215882ef7cd60b5f6be35d67e8909a59bc00e).

Once this is merged. I'll work on the pull request for v10.0.0.

PLANED CHANGES for v10.0.0:

syclik commented 5 years ago

Awesome! I just saw the old PR. Could you let me know how I should test this? (What should I look for when I test it?)

kaz-yos commented 5 years ago

That's a good question! I didn't think about that deeply enough as it "kind of worked" for me. This current PR is supposed to update the language definitions only, so it should do the following as stated in README.md.

So the corresponding "interactive tests" would be:

Also these days RStudio (version >= 1.2) supports Stan syntax highlighting, so we can use it as a reference standard. @jrnold , I would appreciate your thoughts!

jrnold commented 5 years ago

I never got around to figuring out how to do unit tests in Emacs, so I only tested it manually by using the mode with files like @kaz-yos described and also using make compile to pick up some errors.

This is awesome work 👍 If it's okay with @syclik, I would suggest that you take over maintenance of this.

kaz-yos commented 5 years ago

FYI, I figured out how to test indentation and syntax highlighting so these are coming to the next major update (working version https://github.com/kaz-yos/stan-mode/blob/new-features/stan-mode/test-stan-mode.el). I found this very helpful: https://emacs.stackexchange.com/questions/45775/how-can-i-unit-test-my-font-face-rules

The comment style has been simplified in Stan, so I’m considering if this part can be simplified in ‘stan-mode’.

bob-carpenter commented 5 years ago

Thanks. I'll just go ahead and merge as I don't think we have anyone to review this.

syclik commented 5 years ago

Absolutely! Please take over!

On Mon, Aug 5, 2019 at 3:27 PM Bob Carpenter notifications@github.com wrote:

Merged #57 https://github.com/stan-dev/stan-mode/pull/57 into master.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/stan-dev/stan-mode/pull/57?email_source=notifications&email_token=AADH6F2IM4MMKXXV7Z2XDN3QDA2EPA5CNFSM4IHGZTB2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS4CV2TA#event-2533711180, or mute the thread https://github.com/notifications/unsubscribe-auth/AADH6FZZNTWH522QN62BVF3QDA2EPANCNFSM4IHGZTBQ .

kaz-yos commented 5 years ago

@bob-carpenter, could you tag the latest commit as v9.3.0 so that MELPA Stable can take it up.

@jrnold and @syclik, I'm happy to take over the maintainer role. v10.0.0 with company-stan for autocompletion, eldoc-stan for live argument help, and flycheck-stan for on-the-fly stanc is on the horizon. Do I get push access to the stan-dev/stan-mode? What's the workflow? Is it still PR-based regardless of push access?

bob-carpenter commented 5 years ago

@kaz-yos I'm happy to add a tag if you let me know how to do that. Every time I look up something new about Git(Hub) online, I get a StackOverflow dissertation on the subtleties of version control.

kaz-yos commented 5 years ago

@bob-carpenter, I believe you only need to create a release on the Github.

  1. Visit https://github.com/stan-dev/stan-mode/releases
  2. Draft and create a release with the message outlined below with the version v9.3.0.

CHANGES:

Then the MELPA-Stable (https://stable.melpa.org/#/) system should pick up the latest release.

bob-carpenter commented 5 years ago

OK. I think that worked.

Can I somehow give you permission to do this going forward?

On Aug 28, 2019, at 9:24 PM, Kazuki Yoshida notifications@github.com wrote:

@bob-carpenter, I believe you only need to create a release on the Github.

• Visit https://github.com/stan-dev/stan-mode/releases • Draft and create a release with the message outlined below with the version v9.3.0. CHANGES:

• Update stan-mode/stan-keywords-lists.el to support syntax highlighting based for Stan 2.19.0 • Drop obsolete function names such as binomial_cdf_log • Add new function names such as beta_proportion_rng • Update, add, or drop snippets following the above changes Then the MELPA-Stable (https://stable.melpa.org/#/) system should pick up the latest release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

kaz-yos commented 5 years ago

I confirmed a new release v9.3.0. This should trigger the MELPA-Stable system to take up the latest.

Regarding permissions, I would appreciate if you could promote me to the same permission level as @jrnold for the stan-mode repo.

bob-carpenter commented 5 years ago

OK. I invited you to be a maintainer.

Regarding permissions, I would appreciate if you could promote me to the same permission level as @jrnold for the stan-mode repo.