stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.6k stars 370 forks source link

de-spaghettify includes for meta/traits.hpp #1040

Closed bob-carpenter closed 9 years ago

bob-carpenter commented 10 years ago

The meta/traits.hpp file brings in agrad::var and agrad::fvar, which tangles up our math lib with our autodiff lib.

Dependencies should go only one way, from stan::agrad to stan::math, not vice-versa.

Do we want to add a new stan/agrad/mixed directory for things that mix forward and reverse. Right now, that includes autodiff.hpp, which is just defined in stan/agrad/autodiff.hpp. But it would also include any kind of traits or other program that needed to mix forward and reverse mode.

syclik commented 9 years ago

Fixed with #1222.