stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.59k stars 370 forks source link

Move JSON parser from CmdStan to Stan/io #3143

Closed WardBrian closed 2 years ago

WardBrian commented 2 years ago

Submission Checklist

Summary

This is the first half of #3142 and undoes #2803

Intended Effect

Move the JSON parser code from cmdstan to this repo. Tests are also moved.

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

bob-carpenter commented 2 years ago

I can review this when it's ready as long as that's today or early tomorrow or some time later this week.

WardBrian commented 2 years ago

@bob-carpenter this should be ready as-is; it's just a copy-paste job with some renaming of namespaces.

WardBrian commented 2 years ago

I'm going to let the CI here and https://github.com/stan-dev/cmdstan/pull/1120 finish before merging

rok-cesnovar commented 2 years ago

The upstream tests fail because the CmdStan PR was merged, but since all other tests pass feel free to merge.

WardBrian commented 2 years ago

@rok-cesnovar will that prevent the bot from updating the sub modules?

rok-cesnovar commented 2 years ago

I think it should be fine. The test that failed doesnt run on develop I believe.