Closed WardBrian closed 2 years ago
I can review this when it's ready as long as that's today or early tomorrow or some time later this week.
@bob-carpenter this should be ready as-is; it's just a copy-paste job with some renaming of namespaces.
I'm going to let the CI here and https://github.com/stan-dev/cmdstan/pull/1120 finish before merging
The upstream tests fail because the CmdStan PR was merged, but since all other tests pass feel free to merge.
@rok-cesnovar will that prevent the bot from updating the sub modules?
I think it should be fine. The test that failed doesnt run on develop I believe.
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
This is the first half of #3142 and undoes #2803
Intended Effect
Move the JSON parser code from
cmdstan
to this repo. Tests are also moved.How to Verify
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: