stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.59k stars 368 forks source link

[CI] Ensure mac unit and mac interface are running correctly on m1 instance #3166

Closed serban-nicusor-toptal closed 1 year ago

serban-nicusor-toptal commented 1 year ago

…comment out part of Jenkinsfile for faster debug

Submission Checklist

Summary

WRT https://github.com/stan-dev/ci-scripts/issues/24 we've got a new M1 instance that we need to test our CI on to ensure everything is working fine.

Intended Effect

How to Verify

Results should be consistent with the older Mac Instance.

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Toptal

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

serban-nicusor-toptal commented 1 year ago

Everything seems to run fine in here, the problem appears to be a new number of warnings, see https://jenkins.flatironinstitute.org/job/Stan/job/Stan/job/PR-3166/2/pipeline_gcc4/ This is most probably caused by a different version of the dependencies installed on the M1 machine.

WardBrian commented 1 year ago

I think it is probably a newer version of clang which is emitting deprecation warnings.

The right thing to do is probably have the quality gate ignore anything which is under lib/ (meaning all of math, and math's dependencies)

serban-nicusor-toptal commented 1 year ago

I think the cleanest solution would be to ignore the category ,excludeCategory. Seems to be working fine.

WardBrian commented 1 year ago

I think we would still this to fail if we are using deprecated functions in code we control, though. So using excludeFile (which claims it accepts a pattern, so maybe /lib/.* will work?) or something else seems better

serban-nicusor-toptal commented 1 year ago

I don't know why I thought a pattern won't work in excludeFile -.- seems to work fine, thanks! I'll uncomment to make this ready.

WardBrian commented 1 year ago

Is there any reason not to have the label request just be osx after this? In theory it would be fine for either the newer or older machine, no?