Closed WardBrian closed 1 year ago
This seems fine up to the performance tests, which don't yet pass on the stanc3_bin_url parameter so can't be run yet.
I had to revert some of the tests to using ecuyer1988
in e026895 because a fair number of tests here seem to have "magic" seeds and assert on certain values, and I cannot tell if those values were derived somehow of if the existing output was just frozen in the tests
Interesting: Up at the performance-tests-cmdstan level, this change had two models fail https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FCmdStan%20Performance%20Tests/detail/downstream_tests/391/pipeline
One of them is a data generation model which heavily uses RNGs, so it is expected that it would likely change. The other is low_dim_gauss_mix_collapse
(here)
Closing for now, if we ever wanted to make this change it seems like we'd just need to update the magic numbers in a few of our tests
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Experiment to see how viable it is to change RNGs, see #3167 and discussion.
Also needs https://github.com/stan-dev/stanc3/tree/experiment/mixmax-rng
Intended Effect
How to Verify
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: