Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
[x] Declare copyright holder and open-source license: see below
Summary
Closes #3183. This changes the names of the log_p and log_q output columns to log_p__ and log_q__, and moves them to the start to match up with other algorithms.
Unfortunately this was not caught before release, but because cmdstanpy and cmdstanr don't have support for this built-out yet I think we can say that it is a bug fix rather than a breaking change, and release it in 2.32.1 next week (see https://github.com/stan-dev/cmdstan/issues/1154)
I believe the CmdStan implementation also assumes this ordering in its tests, so those may briefly break if we merge this.
Submission Checklist
./runTests.py src/test/unitmake cpplintSummary
Closes #3183. This changes the names of the
log_pandlog_qoutput columns tolog_p__andlog_q__, and moves them to the start to match up with other algorithms.Unfortunately this was not caught before release, but because cmdstanpy and cmdstanr don't have support for this built-out yet I think we can say that it is a bug fix rather than a breaking change, and release it in 2.32.1 next week (see https://github.com/stan-dev/cmdstan/issues/1154)
I believe the CmdStan implementation also assumes this ordering in its tests, so those may briefly break if we merge this.
Documentation
The docs page (https://mc-stan.org/docs/cmdstan-guide/laplace-sampling.html) will need to be updated
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: