Clean up warnings (primarily doxygen) - Githubissues

stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.

https://mc-stan.org

BSD 3-Clause "New" or "Revised" License

2.57k stars 368 forks source link

Clean up warnings (primarily doxygen) #3189

Closed WardBrian closed 1 year ago

WardBrian commented 1 year ago

Submission Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary

After #3179, the quality gate failed due to warnings. Most of these were doxygen related.

As a note it's probably not good that these warning gates can fail a merge after it passes CI in the PR itself.

Intended Effect

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

WardBrian commented 1 year ago

This clears up most of the warnings visible here: https://jenkins.flatironinstitute.org/job/Stan/job/Stan/job/develop/115/pipeline_clang/