stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.57k stars 368 forks source link

Support Tuple indices in Stan CSV Header Reader #3190

Closed WardBrian closed 1 year ago

WardBrian commented 1 year ago

Submission Checklist

Summary

With Tuples, it will no longer be the case that names will always look like x.1.2.1. You can also have a tuple separator indicated by :.

So, for example, a Stan expression x.1[1] will have header x:1.1, y[2].1[3] will be y.2:1.3

Intended Effect

Allow names with : in them for tuples to be parsed properly in the CSV reader

How to Verify

New test added with a header generated by the current compiler branch for Tuples

Side Effects

I also removed some functions no longer needed after #3179

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: