promote logger and writer mock objects from pathfinder utils

stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.

https://mc-stan.org

BSD 3-Clause "New" or "Revised" License

2.57k stars 368 forks source link

promote logger and writer mock objects from pathfinder utils #3194

Open bob-carpenter opened 1 year ago

bob-carpenter commented 1 year ago

Summary:

There are some generally useful testing classes in src/test/unit/services/pathfinder/util.hpp that'd be useful higher up. At that point, they should be renamed to something like mock_writer and mock_logger.

Description:

Also add doc.

Current Version:

v2.32.2

kaifkh20 commented 1 year ago

Is this issue still open?

mitzimorris commented 1 year ago

yes it is still open.

it looks like this is your first time contributing to Stan. a few requests

please read the Stan developer process and guidelines, start here: https://github.com/stan-dev/stan/wiki/Introduction-to-Stan-for-New-Developers
please ask questions! especially of the Stan devs who worked on https://github.com/stan-dev/stan/pull/3123 in order to understand what they're looking for here.