stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.56k stars 366 forks source link

fixes test_logger for mingw #3197

Closed SteveBronder closed 1 year ago

SteveBronder commented 1 year ago

Submission Checklist

Summary

Fixes a bug for mingw we found via Jenkins. Also changes Jenkins so we always test on windows. @serban-nicusor-toptal somewhat related, is there a way to let jenkins know if a PR is in draft mode or not? That would let us skip the windows tests for draft PRs and then for PRs that are not marked as draft we will run the windows test suite.

Intended Effect

Fix mingw bug for ostream

How to Verify

See changes in test_logger

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Steve Bronder

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

WardBrian commented 1 year ago

This looks good to me, within my knowledge of the code being changed. It's been blocking the CI here for a bit, so it would be nice to merge

serban-nicusor-toptal commented 1 year ago

@SteveBronder I think we can do that, we can tie it to the title of a PR ( https://cli.github.com/manual/gh_pr_view ) and skip some tests when it contains [WIP]. I'll create a PR to give it a try.

SteveBronder commented 1 year ago

@serban-nicusor-toptal awesome ty!