Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
[x] Declare copyright holder and open-source license: see below
Summary
Currently, the services functions are inconsistent on whether or not they will throw an exception. The versions which accept num_chains should never throw, but the older ones will throw if initialization fails.
This consistently puts utils::initialize in a try block.
Additionally, we are currently using logger.info for messages which are errors, and in several places not logging an error where we could (e.g., the catch blocks accompanying the above trys).
Intended Effect
Improved error logging and exception safety in the services functions
How to Verify
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Currently, the services functions are inconsistent on whether or not they will throw an exception. The versions which accept
num_chains
should never throw, but the older ones will throw if initialization fails. This consistently putsutils::initialize
in atry
block.Additionally, we are currently using
logger.info
for messages which are errors, and in several places not logging an error where we could (e.g., thecatch
blocks accompanying the abovetry
s).Intended Effect
Improved error logging and exception safety in the services functions
How to Verify
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: