stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.59k stars 368 forks source link

Fix typo in quality gate filter #3216

Closed serban-nicusor-toptal closed 1 year ago

serban-nicusor-toptal commented 1 year ago

Submission Checklist

Summary

Fix a typo in the quality gate filter, this fails downstream tests in Math by being unstable, see pipeline.

Intended Effect

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Toptal

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

serban-nicusor-toptal commented 1 year ago

In cmdstan we only have warnings from

clang: warning: -Wl,-L,/Users/jenkins/workspace/Stan_CmdStan_develop/stan/lib/stan_math/lib/tbb: 'linker' input unused [-Wunused-command-line-argument]

So the following filter does the trick:

excludeFile('stan/lib/stan_math/lib/*')
WardBrian commented 1 year ago

https://github.com/stan-dev/cmdstan/pull/1143 has the quality gate complaining

serban-nicusor-toptal commented 1 year ago

Oh, that's weird, it comes from the MacOS SDK

stan/lib/stan_math/lib/boost_1.78.0/boost/assert/source_location.hpp:80:18: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
            std::sprintf( buffer, ":%ld", static_cast<long>( column() ) );
                 ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
__deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
        #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                      ^

And the Jenkins plugin sees it as a different warning/path. I'll run a new build on your PR to try and filter it.