stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.56k stars 366 forks source link

Merge release v2.33.0 into master #3225

Closed serban-nicusor-toptal closed 10 months ago

serban-nicusor-toptal commented 10 months ago

Submission Checklist

Summary

Merge release v2.33.0 into master

Intended Effect

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

WardBrian commented 10 months ago

What are we doing wrong that makes it so there are merge conflicts on these every release?

serban-nicusor-toptal commented 10 months ago

A long time ago, this was done by the following:

git checkout master
git reset --hard v$version
git push origin master

I would assume that messed up the branch history... Even after a rebase we're stuck with a bunch of conflicts. The easy way is to do it like the above, the hard way fix the conflicts and align the history.

serban-nicusor-toptal commented 10 months ago

Closed this and the one in cmdstan as I want to merge release/v2.33.0 into master which is hardcoding the submodules to the release.