Use stan::test::is_valid_JSON consistently - Githubissues

stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.

https://mc-stan.org

BSD 3-Clause "New" or "Revised" License

2.56k stars 366 forks source link

Use stan::test::is_valid_JSON consistently #3232

Closed WardBrian closed 10 months ago

WardBrian commented 10 months ago

Submission Checklist

[x] Run unit tests: ./runTests.py src/test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary

Follow up on #3230, uses the new utility function in a couple places we were directly using RapidJSON for testing

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

WardBrian commented 10 months ago

Yes, I have one I’m working on