stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.6k stars 370 forks source link

Fix nondeterminism in multi-Pathfinder #3239

Closed WardBrian closed 1 year ago

WardBrian commented 1 year ago

Submission Checklist

Summary

The current design is such that the order of the single-pathfinder draws is determined by the order their thread completes, so a random seed does not always produce the same output of multi-pathfinder.

More details are given in #3237

Intended Effect

Closes #3237

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: