Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
[x] Declare copyright holder and open-source license: see below
Summary
We've been recommending against using the R dump format for a while (see https://github.com/stan-dev/cmdstan/pull/1177), but we were still using it for a lot of tests (sometimes completely unnecessarily), and for the two helper functions create_unit_e_diag_inv_metric and create_unit_e_dense_inv_metric, which were both implemented by creating a string and then parsing it again.
Intended Effect
Clean up unnecessary usages of io::dump in tests, replace others with json data, and refactor utilities that don't need to do parsing to not do it.
How to Verify
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
We've been recommending against using the R dump format for a while (see https://github.com/stan-dev/cmdstan/pull/1177), but we were still using it for a lot of tests (sometimes completely unnecessarily), and for the two helper functions
create_unit_e_diag_inv_metric
andcreate_unit_e_dense_inv_metric
, which were both implemented by creating a string and then parsing it again.Intended Effect
Clean up unnecessary usages of
io::dump
in tests, replace others with json data, and refactor utilities that don't need to do parsing to not do it.How to Verify
Side Effects
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: