search

stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.55k stars 365 forks source link

Pathfinder: stop returning more draws than requested #3279

Closed WardBrian closed 2 months ago

WardBrian commented 2 months ago

Submission Checklist

Summary

Closes #3268. Now when the number of draws requested is smaller than the number of draws the ELBO calculations do internally, they are truncated to the expected size rather than all returned.

I also fixed up #3278

Intended Effect

How to Verify

I have a test in another project, I wasn't sure if we wanted to adapt one for here or not.

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

stan-buildbot commented 2 months ago
Name Old Result New Result Ratio Performance change( 1 - new / old )
eight_schools/eight_schools.stan 0.06 0.05 1.07 6.31% faster
pkpd/one_comp_mm_elim_abs.stan 18.14 18.65 0.97 -2.8% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.25 0.26 0.97 -3.27% slower
arK/arK.stan 1.61 1.7 0.95 -5.01% slower
gp_pois_regr/gp_pois_regr.stan 2.5 2.62 0.95 -4.9% slower
gp_regr/gen_gp_data.stan 0.02 0.02 0.93 -7.16% slower
gp_regr/gp_regr.stan 0.11 0.11 0.98 -2.29% slower
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 9.15 9.5 0.96 -3.88% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.8 2.94 0.95 -5.13% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 1.02 1.68% faster
garch/garch.stan 0.46 0.49 0.93 -7.46% slower
arma/arma.stan 0.19 0.21 0.92 -8.69% slower
irt_2pl/irt_2pl.stan 3.83 4.02 0.95 -4.74% slower
sir/sir.stan 77.55 79.33 0.98 -2.3% slower
performance.compilation 181.49 194.89 0.93 -7.39% slower

Mean result: 0.9646677760192356

Jenkins Console Log Blue Ocean Commit hash: fb02dc7240781e4fe7ea4bc1fb4e06e70079765a

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal CPU: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 46 bits physical, 48 bits virtual CPU(s): 80 On-line CPU(s) list: 0-79 Thread(s) per core: 2 Core(s) per socket: 20 Socket(s): 2 NUMA node(s): 2 Vendor ID: GenuineIntel CPU family: 6 Model: 85 Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz Stepping: 4 CPU MHz: 3700.000 CPU max MHz: 3700.0000 CPU min MHz: 1000.0000 BogoMIPS: 4800.00 Virtualization: VT-x L1d cache: 1.3 MiB L1i cache: 1.3 MiB L2 cache: 40 MiB L3 cache: 55 MiB NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78 NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79 Vulnerability Itlb multihit: KVM: Mitigation: Split huge pages Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable Vulnerability Meltdown: Mitigation; PTI Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable Vulnerability Retbleed: Mitigation; IBRS Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS Not affected Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts pku ospke md_clear flush_l1d arch_capabilities G++: g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0 Copyright (C) 2019 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Clang: clang version 10.0.0-4ubuntu1 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin