search

stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.6k stars 370 forks source link

Review the Issues list please? #3297

Open MaderDash opened 4 months ago

MaderDash commented 4 months ago

Summary:

There are currently 138 open issues. Is this an accurate reflection of the situation?

Description:

I'm willing to assist in any way possible, but could we first confirm if there are still active issues from as far back as 2013? It would be beneficial if someone could review the issue list and close any tasks that are no longer relevant. If they are indeed still open, perhaps we could compile a list of high-priority items needing immediate assistance and highlight them accordingly, so we can contribute where possible. Also reviewing and updating the tags on the issue would be nice also?

Expected Output:

It's somewhat ironic that I'm trying to help reduce the issue list, yet I'm adding another issue to the list in an effort to do so. :D

image

Just trying to help out. :D

Current Version:

v2.35.0

bob-carpenter commented 4 months ago

Hi, @MaderDash and thanks for looking.

When we see dead issues, we try to close them. We're not always successful in keeping up. The older ones are more likely to be valid because we do review from time to time. The issues are both feature requests and bug reports. This is only part of Stan that's related to algorithms and I/O. Most of the math is in the math repo, the parser is in the stand repo, the interfaces are in their own repos, etc. So it's a lot worse than it looks from just the Stan repo---we have thousands of open issues across repos.

We'd welcome any review on this. Please discuss before closing unless it's totally obvious it's a bug that's been fixed. You can also show up to our Thursday dev meetings at 11 am NY time to discuss (online link from the forums under "Stan the gathering"), but most of us are at ISBA this week.

We do review these pretty regularly, or I should say @WardBrian has been doing that. Of the ones that show up on that list you included, I think the Jacobians may have been vectorized already---@stevebronder will know. The other ones have not been addressed and are still valid.

WardBrian commented 4 months ago

As Bob said, I have tried to ensure most of the open issues are not things that have already been implemented. I've been much more conservative closing issues for things that are not done, but may no longer be desirable, so an older issue being open is still not the strongest signal that something actionable is there.