Closed mitzimorris closed 1 month ago
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.34 | 0.31 | 1.08 | 7.82% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 1.06 | 5.88% faster |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.1 | 9.44% faster |
gp_regr/gp_regr.stan | 0.11 | 0.09 | 1.25 | 20.01% faster |
sir/sir.stan | 69.35 | 69.97 | 0.99 | -0.89% slower |
irt_2pl/irt_2pl.stan | 4.16 | 4.3 | 0.97 | -3.17% slower |
eight_schools/eight_schools.stan | 0.06 | 0.06 | 0.99 | -1.15% slower |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.25 | 0.25 | 0.99 | -1.17% slower |
pkpd/one_comp_mm_elim_abs.stan | 19.44 | 19.83 | 0.98 | -2.03% slower |
garch/garch.stan | 0.43 | 0.42 | 1.02 | 2.38% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.69 | 2.64 | 1.02 | 1.88% faster |
arK/arK.stan | 1.77 | 1.74 | 1.02 | 1.78% faster |
gp_pois_regr/gp_pois_regr.stan | 2.76 | 2.71 | 1.02 | 2.03% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 8.72 | 8.4 | 1.04 | 3.65% faster |
performance.compilation | 182.82 | 184.7 | 0.99 | -1.03% slower |
Mean result: 1.0353015643491215
Jenkins Console Log Blue Ocean Commit hash: c83a397be67c59ba135871db25c53717e78d796e
This is causing a failure on jenkins in another pr in the math library. Can we revert this, update it to develop, and open another pr?
@SteveBronder that failure was from before this was merged, does it still happen now?
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
PR https://github.com/stan-dev/stan/pull/3071 had a failing unit test; this PR fixes that test and adds a test to demonstrate that the adaptive sampler can be run on a model with zero parameters.
Intended Effect
Interfaces don't need to enforce calls to "fixed_param" sampler for models with zero params.
How to Verify
Unit tests
Side Effects
N/A
Documentation
N/A
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: