stan-dev / stan

Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
2.6k stars 370 forks source link

Bugfix/3301 stan csv reader #3311

Closed mitzimorris closed 1 month ago

mitzimorris commented 1 month ago

Submission Checklist

Summary

Better parsing of Stan CSV files to allow for getting MCMC sample from fixed_param and samples with saved warmup draws (bug #3301) and be able to correctly get ADVI sample.

Intended Effect

Always provide valid sample from parsed stan_csv object.

How to Verify

Unit tests

Side Effects

Methods to parse segments of the Stan CSV file - header, etc. no longer take argument out to record warnings and instead throw std::invalid_input errors.

Documentation

N/A

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

mitzimorris commented 1 month ago

ready for review. this will cause CmdStan's bin/stansummary to fail.

mitzimorris commented 1 month ago

have branch of CmdStan queued up here: https://github.com/stan-dev/cmdstan/tree/update/3301-stan-csv-reader can submit PR on CmdStan