Stan development repository. The master branch contains the current release. The develop branch contains the latest stable development. See the Developer Process Wiki for details.
[x] Declare copyright holder and open-source license: see below
Summary
Better parsing of Stan CSV files to allow for getting MCMC sample from fixed_param and samples with saved warmup draws (bug #3301) and be able to correctly get ADVI sample.
Intended Effect
Always provide valid sample from parsed stan_csv object.
How to Verify
Unit tests
Side Effects
Methods to parse segments of the Stan CSV file - header, etc. no longer take argument out to record warnings and instead throw std::invalid_input errors.
Documentation
N/A
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Better parsing of Stan CSV files to allow for getting MCMC sample from fixed_param and samples with saved warmup draws (bug #3301) and be able to correctly get ADVI sample.
Intended Effect
Always provide valid sample from parsed
stan_csv
object.How to Verify
Unit tests
Side Effects
Methods to parse segments of the Stan CSV file - header, etc. no longer take argument
out
to record warnings and instead throwstd::invalid_input
errors.Documentation
N/A
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: