Do not let dune automatically guess root dir in CI - Githubissues

stan-dev / stanc3

The Stan transpiler (from Stan to C++ and beyond).

BSD 3-Clause "New" or "Revised" License

140 stars 44 forks source link

Do not let dune automatically guess root dir in CI #1249

Closed serban-nicusor-toptal closed 2 years ago

serban-nicusor-toptal commented 2 years ago

Use --root when running in isolated directories to avoid dune automatically guessing the root directory in CI.

Submission Checklist

[ ] Run unit tests
Documentation
- [ ] If a user-facing facing change was made, the documentation PR is here:
- [ ] OR, no user-facing changes were made

Release notes

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

WardBrian commented 2 years ago

I believe we also need to update https://github.com/stan-dev/stanc3/blob/04841ef46c5ad3eeabb5d036bf00c10fe180d087/scripts/build_multiarch_stanc3.sh#L28

serban-nicusor-toptal commented 2 years ago

I think it's good to merge now. https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/PR-1249/5/pipeline https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/PR-1249/4/pipeline