stan-dev / stanc3

The Stan transpiler (from Stan to C++ and beyond).
BSD 3-Clause "New" or "Revised" License
138 stars 44 forks source link

Build backwards-compatible Mac executables on flatiron mac #1255

Closed serban-nicusor-toptal closed 1 year ago

serban-nicusor-toptal commented 1 year ago

Submission Checklist

Release notes

CI change, build backwards-compatible Mac executables on flatiron mac.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

WardBrian commented 1 year ago

@serban-nicusor-toptal did you confirm the built binaries from this run on the old gelman-mac?

serban-nicusor-toptal commented 1 year ago

Hey @WardBrian I think it's ready for review. I ran a test job here: https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/PR-1255/2/artifacts Where you can find the binary, I ran it on the gelman mac ( --help ) and it seems to work fine.

serban-nicusor-toptal commented 1 year ago

I will give it another try on the old-imac instance. ( also --help )

d1m1s1b1:tmp XXX$ ./mac-stanc --version
stanc3 v2.30.0-66-g8fe98f94 (Unix)
d1m1s1b1:tmp XXX$ sw_vers
ProductName:    Mac OS X
ProductVersion: 10.13.4
BuildVersion:   17E199
gelman-group-mac:tmp XXX$ ./mac-stanc --version
stanc3 v2.30.0-66-g8fe98f94 (Unix)
gelman-group-mac:tmp XXX$ sw_vers
ProductName:    Mac OS X
ProductVersion: 10.11.6
BuildVersion:   15G22010
WardBrian commented 1 year ago

Awesome, thanks!

serban-nicusor-toptal commented 1 year ago

Thank you too for the work on this! Will merge the PR now.