Use full return type in --standalone-functions definitions

stan-dev / stanc3

The Stan transpiler (from Stan to C++ and beyond).

BSD 3-Clause "New" or "Revised" License

138 stars 44 forks source link

Use full return type in --standalone-functions definitions #1313

Closed WardBrian closed 1 year ago

WardBrian commented 1 year ago

Closes #1312

Submission Checklist

[x] Run unit tests
Documentation
- [x] OR, no user-facing changes were made

Release notes

--standalone-functions now generates signatures which have the return type written out in full, rather than using auto.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

WardBrian commented 1 year ago

@andrjohns does this look like it would solve the issue you ran into?

andrjohns commented 1 year ago

Yep, perfect!

codecov[bot] commented 1 year ago

Codecov Report

Merging #1313 (98effdf) into master (d639c9b) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
- Coverage   89.01%   89.01%   -0.01%     
==========================================
  Files          64       64              
  Lines        9777     9775       -2     
==========================================
- Hits         8703     8701       -2     
  Misses       1074     1074

Impacted Files	Coverage Δ
src/stan_math_backend/Lower_functions.ml	`99.45% <100.00%> (-0.01%)`	:arrow_down: