stan-dev / stanc3

The Stan transpiler (from Stan to C++ and beyond).
BSD 3-Clause "New" or "Revised" License
138 stars 44 forks source link

Ensure proper cleanup during CI stage #1330

Closed serban-nicusor-toptal closed 1 year ago

serban-nicusor-toptal commented 1 year ago

Submission Checklist

Release notes

Because we do not clean after VerifyChanges master is keeping an older state on disk, this PR fixes this behavior.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

serban-nicusor-toptal commented 1 year ago

I think this fixed it @WardBrian the problem was that we never cleaned up after Verify Changes so it was keeping the old files there thus an older version of master. I will need to apply this fix to Math, Stan, CmdStan too.

WardBrian commented 1 year ago

@serban-nicusor-toptal the merge on this to master then failed - https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/master/210/pipeline

Weird, because it seems unrelated to the added rm command?

serban-nicusor-toptal commented 1 year ago

It's because of trying to git diff with origin/{hash} which seems to not work for hashes, I reverted that and we're good!

WardBrian commented 1 year ago

Thanks!