Update log_sum_exp sigs and test

stan-dev / stanc3

The Stan transpiler (from Stan to C++ and beyond).

BSD 3-Clause "New" or "Revised" License

140 stars 44 forks source link

Closed andrjohns closed 1 year ago

andrjohns commented 1 year ago

[x] Run unit tests
Documentation
- [x] If a user-facing facing change was made, the documentation PR is here: https://github.com/stan-dev/docs/pull/662
- [ ] OR, no user-facing changes were made

Updated signatures for vectorised binary log_sum_exp

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

WardBrian commented 1 year ago

@andrjohns it looks like the test file has a typo which is causing the CI failures. Otherwise this seems good to go if you can fix that up

WardBrian commented 1 year ago

How difficult is it to make the vectorization framework work with SoA matrices?