stan-dev / stanc3

The Stan transpiler (from Stan to C++ and beyond).
BSD 3-Clause "New" or "Revised" License
138 stars 44 forks source link

Mark binomial logit and glm as opencl-supported #1368

Open andrjohns opened 8 months ago

andrjohns commented 8 months ago

Submission Checklist

This PR marks the binomial_logit and binomial_logit_glm distributions as OpenCL-supported. The binomial_logit_glm support was only recently added, but the binomial_logit distributions appears to have already had support but just hadn't been enabled.

Let me know if I've missed any tests/checks that also need to be made!

Release notes

Enabled OpenCL support for the binomial_logit and binomial_logit_glm distributions

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

codecov[bot] commented 8 months ago

Codecov Report

Merging #1368 (1e046c5) into master (6b62412) will decrease coverage by 0.48%. Report is 14 commits behind head on master. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
- Coverage   89.93%   89.46%   -0.48%     
==========================================
  Files          63       65       +2     
  Lines       10704    10778      +74     
==========================================
+ Hits         9627     9642      +15     
- Misses       1077     1136      +59     
Files Coverage Δ
src/middle/Stan_math_signatures.ml 98.15% <100.00%> (+<0.01%) :arrow_up:
src/stan_math_backend/Transform_Mir.ml 95.73% <ø> (+<0.01%) :arrow_up:

... and 63 files with indirect coverage changes

WardBrian commented 8 months ago

With #1353 this may be obsolete by the next release but I don't see any harm in marking it supported if it is

andrjohns commented 8 months ago

With #1353 this may be obsolete by the next release but I don't see any harm in marking it supported if it is

Oh neat, that will be really nice to have