stan-dev / stanc3

The Stan transpiler (from Stan to C++ and beyond).
BSD 3-Clause "New" or "Revised" License
138 stars 44 forks source link

Update js_of_ocaml to 5.5.2 #1381

Closed WardBrian closed 6 months ago

WardBrian commented 6 months ago

The recent 5.5 release of js_of_ocaml featured some pretty big improvements to the dead code elimination phase which makes the produced file smaller. On my machine, this is a nearly 15% improvement:

-r--r--r--  1 brian brian 1873308 Dec  8 10:13 stancjs.4.1.0.bc.js
-r--r--r--  1 brian brian 1608773 Dec  8 10:18 stancjs.5.5.2.bc.js

In terms of speed, it seems to be essentially the same, maybe slightly faster, but definitely within the range that the noise on my machine makes benchmarking unable to tell the difference between the two versions.

Submission Checklist

Release notes

Updated js_of_ocaml to version 5.5.2

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

codecov[bot] commented 6 months ago

Codecov Report

Merging #1381 (3433c6a) into master (992ff90) will increase coverage by 89.93%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1381 +/- ## =========================================== + Coverage 0 89.93% +89.93% =========================================== Files 0 63 +63 Lines 0 10699 +10699 =========================================== + Hits 0 9622 +9622 - Misses 0 1077 +1077 ``` [see 63 files with indirect coverage changes](https://app.codecov.io/gh/stan-dev/stanc3/pull/1381/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stan-dev)