stan-dev / stanc3

The Stan transpiler (from Stan to C++ and beyond).
BSD 3-Clause "New" or "Revised" License
140 stars 44 forks source link

Mark 'jacobian' as reserved for future use #1397

Closed WardBrian closed 8 months ago

WardBrian commented 8 months ago

See https://github.com/stan-dev/design-docs/pull/52.

While that design may not be the final one that is approved, I think getting some sort of warning in early is probably useful.

Submission Checklist

Release notes

Giving a variable the name jacobian is now deprecated. This name is being reserved for future language extensions.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8f2dbe7) 89.88% compared to head (6bb1ba1) 89.88%. Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1397 +/- ## ======================================= Coverage 89.88% 89.88% ======================================= Files 63 63 Lines 10505 10507 +2 ======================================= + Hits 9442 9444 +2 Misses 1063 1063 ``` | [Files](https://app.codecov.io/gh/stan-dev/stanc3/pull/1397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stan-dev) | Coverage Δ | | |---|---|---| | [src/frontend/Input\_warnings.ml](https://app.codecov.io/gh/stan-dev/stanc3/pull/1397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=stan-dev#diff-c3JjL2Zyb250ZW5kL0lucHV0X3dhcm5pbmdzLm1s) | `100.00% <100.00%> (ø)` | |