WardBrian
commented
6 months ago Examples of the new message:
Syntax error in 'declarations.stan', line 3, column 18 to column 18, parsing error:
-------------------------------------------------
1: data {
2: int a0;
3: int<lower=0> a1[1];
^
4: int a2[2,3];
5: array[1] int a3;
-------------------------------------------------
";" expected after variable declaration.
It looks like you are trying to use the old array syntax.
Please use the new syntax:
array[...] int<lower=0> a1;Syntax error in 'unsized-old-array.stan', line 2, column 18 to column 18, parsing error:
-------------------------------------------------
1: functions{
2: real foo( real[,] v){
^
3: return sum(v);
4: }
-------------------------------------------------
An identifier is expected after the type as a function argument name.
It looks like you are trying to use the old array syntax.
Please use the new syntax:
array[...] real(how does this look @andrjohns?)
codecov[bot]
Closes #1412. Surprisingly, this doesn't introduce any conflicts in the parser. If it ever does, we could remove it again, but for now it seems like a good quality of life feature.
One downside is printing a nice error message introduced a circular dependency between pretty printing and parsing. I resolved this by splitting the pretty printing module in two, but I'm not super happy with that.
Submission Checklist
Release notes
Added a better error message when a program attempts to use the removed array syntax.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)