[CI] Switch to gh binary for releases

stan-dev / stanc3

The Stan transpiler (from Stan to C++ and beyond).

BSD 3-Clause "New" or "Revised" License

138 stars 44 forks source link

[CI] Switch to gh binary for releases #1419

Closed serban-nicusor-toptal closed 2 months ago

serban-nicusor-toptal commented 2 months ago

Submission Checklist

[ ] Run unit tests
Documentation
- [ ] If a user-facing facing change was made, the documentation PR is here:
- [ ] OR, no user-facing changes were made

Release notes

Requested in #1418, this will replace the ghr binary with the official gh binary from Github.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

serban-nicusor-toptal commented 2 months ago

I've added gh in the publish Dockerfile and replaced the ghr command, in theory, it should all work smoothly. I think the easiest way to test this is to merge it into master and stay sharp in case anything goes wrong so I can fix it. If you don't mind Brian to take a look at the flags I added, in case we want to add/remove any. Thanks!

WardBrian commented 2 months ago

Oh, I think you might need to \$ to escape the git log command