Rollback JSOO version for QuickJS compatibility

stan-dev / stanc3

The Stan transpiler (from Stan to C++ and beyond).

BSD 3-Clause "New" or "Revised" License

138 stars 44 forks source link

Rollback JSOO version for QuickJS compatibility #1427

Closed andrjohns closed 1 month ago

andrjohns commented 1 month ago

Submission Checklist

Closes #1425

[x] Run unit tests
Documentation
- [ ] If a user-facing facing change was made, the documentation PR is here:
- [x] OR, no user-facing changes were made

Release notes

Rollback js_of_ocaml to 5.4.0 for compatibility with QuickJS

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

WardBrian commented 1 month ago

Are we also pursuing a fix in quickjs? I don't want to have a version pinning here which is stuck indefinitely because another package doesn't correctly implement part of javascript

andrjohns commented 1 month ago

Are we also pursuing a fix in quickjs? I don't want to have a version pinning here which is stuck indefinitely because another package doesn't correctly implement part of javascript

They've said that they're aware of the bug, so I guess so.

It's easy enough to revisit later if there's a compelling reason to upgrade