stanch / reftree

Automatically generated diagrams and animations for Scala data structures
http://stanch.github.io/reftree/
GNU General Public License v3.0
587 stars 36 forks source link

Publish for Scala 2.12 #22

Closed andyscott closed 1 month ago

andyscott commented 6 years ago

Currently this project is only published for Scala 2.11. I would love to use it for generating some documentation in Scala 2.12.

stanch commented 6 years ago

Could you try adding resolvers += Resolver.bintrayRepo("stanch", "reftree")? The project is published for both 2.11 and 2.12, but the jCenter repo (which sbt uses by default) somehow only shows one version. See #16 and #17.

andyscott commented 6 years ago

I get the following error:

Downloading https://repo1.maven.org/maven2/org/stanch/reftree_2.12/1.2.0/reftree_2.12-1.2.0.pom.sha1
Downloading https://repo1.maven.org/maven2/org/stanch/reftree_2.12/1.2.0/reftree_2.12-1.2.0.pom
Downloading https://dl.bintray.com/stanch/reftree/org/stanch/reftree_2.12/1.2.0/reftree_2.12-1.2.0.pom
Downloading https://dl.bintray.com/stanch/reftree/org/stanch/reftree_2.12/1.2.0/reftree_2.12-1.2.0.pom.sha1
Downloading https://repo1.maven.org/maven2/org/stanch/reftree_sjs0.6_2.12/1.2.0/reftree_sjs0.6_2.12-1.2.0.pom
Downloading https://repo1.maven.org/maven2/org/stanch/reftree_sjs0.6_2.12/1.2.0/reftree_sjs0.6_2.12-1.2.0.pom.sha1
Downloading https://dl.bintray.com/stanch/reftree/org/stanch/reftree_sjs0.6_2.12/1.2.0/reftree_sjs0.6_2.12-1.2.0.pom
Downloading https://dl.bintray.com/stanch/reftree/org/stanch/reftree_sjs0.6_2.12/1.2.0/reftree_sjs0.6_2.12-1.2.0.pom.sha1
[error] coursier.ResolutionException: Encountered 1 error(s) in dependency resolution:
[error]     org.stanch:reftree_2.12:1.2.0:
[error]         not found:
[error]             /Users/andyscott/.ivy2/local/org.stanch/reftree_2.12/1.2.0/ivys/ivy.xml
[error]             https://repo1.maven.org/maven2/org/stanch/reftree_2.12/1.2.0/reftree_2.12-1.2.0.pom
[error]             https://dl.bintray.com/stanch/reftree/org/stanch/reftree_2.12/1.2.0/reftree_2.12-1.2.0.pom
[error] coursier.ResolutionException: Encountered 1 error(s) in dependency resolution:
[error]     org.stanch:reftree_sjs0.6_2.12:1.2.0:
[error]         not found:
[error]             /Users/andyscott/.ivy2/local/org.stanch/reftree_sjs0.6_2.12/1.2.0/ivys/ivy.xml
[error]             https://repo1.maven.org/maven2/org/stanch/reftree_sjs0.6_2.12/1.2.0/reftree_sjs0.6_2.12-1.2.0.pom
[error]             https://dl.bintray.com/stanch/reftree/org/stanch/reftree_sjs0.6_2.12/1.2.0/reftree_sjs0.6_2.12-1.2.0.pom
[error] (core / coursierResolutions) coursier.ResolutionException: Encountered 1 error(s) in dependency resolution:
[error]     org.stanch:reftree_2.12:1.2.0:
[error]         not found:
[error]             /Users/andyscott/.ivy2/local/org.stanch/reftree_2.12/1.2.0/ivys/ivy.xml
[error]             https://repo1.maven.org/maven2/org/stanch/reftree_2.12/1.2.0/reftree_2.12-1.2.0.pom
[error]             https://dl.bintray.com/stanch/reftree/org/stanch/reftree_2.12/1.2.0/reftree_2.12-1.2.0.pom
sbt:root> [error] (coreJS / coursierResolutions) coursier.ResolutionException: Encountered 1 error(s) in dependency resolution:
[error]     org.stanch:reftree_sjs0.6_2.12:1.2.0:
[error]         not found:
[error]             /Users/andyscott/.ivy2/local/org.stanch/reftree_sjs0.6_2.12/1.2.0/ivys/ivy.xml
[error]             https://repo1.maven.org/maven2/org/stanch/reftree_sjs0.6_2.12/1.2.0/reftree_sjs0.6_2.12-1.2.0.pom
[error]             https://dl.bintray.com/stanch/reftree/org/stanch/reftree_sjs0.6_2.12/1.2.0/reftree_sjs0.6_2.12-1.2.0.pom
[error] Total time: 1 s, completed Jul 24, 2018 7:05:27 PM
andyscott commented 6 years ago

Seems to work if I add resolvers += Resolver.bintrayRepo("stanch", "reftree") and resolvers += Resolver.bintrayRepo("stanch", "maven"), though.

Could I convince you to publish this to some more standard repositories? I'd like to consume this from some Bazel builds that pull from a proxied maven repo. The proxy repo isn't configured to pull from non-default Scala maven repositories.

stanch commented 6 years ago

Sorry, I actually meant Resolver.bintrayRepo("stanch", "maven"), but I wrongly copied it from #17. I’ll try to publish to Maven Central, but it might take a few days. Just opened a request here: https://issues.sonatype.org/browse/OSSRH-41441.

stanch commented 6 years ago

Update: the first step is done, https://github.com/stanch/zipper (which is a dependency) is making its way to Maven Central. Tomorrow I should be able to publish this one as well.

andyscott commented 6 years ago

\o/ Awesome, thanks for the update!

stanch commented 6 years ago

Done! https://oss.sonatype.org/#nexus-search;quick~stanch. Should take a few hours to appear on search.maven.com. Meanwhile, I still need to update the website, but npm/gitbook is acting up...

rajcspsg commented 3 years ago

@stanch - Could you please publish this for scala 2.13 version as well? It depends on "io.github.stanch" %% "zipper" % "0.5.2" for which no 2.13 release exists

stanch commented 3 years ago

Hi @rajcspsg and sorry for the late response. First of all, thanks for your interest in this library. I have not been actively working with Scala or following the developments in the community for the past couple of years, so I am not sure what the effort of migrating to 2.13 would be. For example, I suspect that the standard RefTree instances need to be updated to work with 2.13 collections. That said, I am happy to accept pull requests that bump both github.com/stanch/zipper and this project to 2.13, update the dependencies, etc. After that, publishing should be a matter of tagging a new version.

rajcspsg commented 3 years ago

@stanch - I've updated scala version to 2.12 https://github.com/stanch/reftree/pull/28 . I've tested and it is working fine. For 2.13 I need to updated the dependencies. I will work on it and send different PR soon.

danicheg commented 1 month ago

I think this can be safely closed since we not only have support for 2.12 but also support for 2.13 is coming soon

stanch commented 1 month ago

Published to Maven Central for 2.12 and 2.13: https://github.com/stanch/reftree/actions/runs/9870959685/job/27258462126. Should be live in some minutes.