Closed danicheg closed 1 month ago
As usual, to get the Github Actions Workflows to run, they must be in the master
branch š¤·š»
Meanwhile, I managed to run and debug the CI pipelines (except for publishing, for sure) within my fork, and it appears to be 'green' https://github.com/danicheg/reftree/actions/runs/9627261707/job/26554149707.
This is amazing, thank you so much for breathing life into this project :)
I will be able to take a closer look tomorrow. If itās not too much trouble to pull all => changes into a separate PR to ease the review, that would be appreciated, but if not thatās ok. (Yes, I drank too much unicode kool-aid back in the day, sorry!)
Donāt worry about the site. Last time I tried Gitbook a few years ago, it was broken already. The solution is to move to Docusaurus and I think I can do that relatively easily.
If itās not too much trouble to pull all => changes into a separate PR to ease the review, that would be appreciated, but if not thatās ok.
Unfortunately, these changes are forced by scalac https://github.com/scala/scala/pull/7540. Therefore, putting them in a separate PR would lead to a broken build in Scala 2.13.
The solution is to move to Docusaurus and I think I can do that relatively easily.
Funnily, I also thought about migrating to Docusaurus and decided to discuss this first :)
Therefore, putting them in a separate PR would lead to a broken build in Scala 2.13.
I assumed this PR would then be against the branch of the other PR. But never mind, itās not a huge obstacle.
I assumed this PR would then be against the branch of the other PR. But never mind, itās not a huge obstacle.
Ahh, I see.
@stanch I know this PR looks monstrous, let me know if I should make it more accessible.
I think itās fine as it is ā my plan is to merge and do some sanity checks on the 2.13 collection instances. Iāll try to find some time tomorrow. Sorry for not being faster, most of my free time is now spent building a chair š
Iāll try to find some time tomorrow. Sorry for not being faster, most of my free time is now spent building a chair
Take your time, no rush at all. Building a chair sounds awesome, especially when you're bored with these damn computers.
Unfortunately, a miracle hasn't happened, and microsite building/publishing failed. So, let's try to migrate to Docusaurus?
Yeah, Iāll take a stab at that!
@danicheg Check this out: https://github.com/stanch/reftree/commit/37ddf66c969774454abbc4753bf44bc533cf467b.
Itās live: http://stanch.github.io/reftree/docs
I had to make a few concessions to keep my sanity:
Contributions are welcome :P
Iāll likely do a release tomorrow, still need to fix something in the build for that.
@stanch nicely done!
Resolves #35
Alongside adding Scala 2.13 support, some other things have been done:
1.5.0
->1.10.0
and all its plugins to up-to-date versions2.12.19
tut
tomdoc
I tested that PR against Scala 2.12 and Scala 2.13 on JVM and JS platforms. It works fine. The only thing I'm concerned about is that we might have issues with building and publishing the website. I migrated the corresponding SBT plugins according to the docs but failed to bootstrap the site locally. I agree it sounds disappointing, and it might be a blocker for getting this PR merged. However, maybe someone will express interest in putting on the finishing touches, or I will find time to do that.