search

stancl / tenancy-docs

stancl/tenancy docs & website
https://tenancyforlaravel.com/docs
MIT License
62 stars 605 forks source link

fixes confusing typo on Tenants page #236

Closed caseydwyer closed 1 year ago

caseydwyer commented 1 year ago

Don't know what exactly this line is referring to (eg, CentralConnection concern, the $tenant->run... function, or something else)...but I'm 95% sure this was a typo in one direction or the other. Hope that helps!

stancl commented 1 year ago

It means that you can interact with Tenant models even in the tenant context. The tenants table is in the central DB, so to be able to work with the current Tenant model properly, it needs to use a forced central connection.

The uppercase Tenant should make it clear here. If you think it's confusing maybe we can make it Tenant instead of just Tenant.

caseydwyer commented 1 year ago

Ah, that makes sense. Yeah, that's (obviously) totally your call, but IMHO maybe helpful to indicate that the Tenant here is referring to the Tenant record from the central DB. That's my bad though, just misinterpreted that line. Sorry for the trouble, feel free to close this out if you'd prefer to leave as-is!