search

standard-release / app

Language independent GitHub App for creating GitHub Releases, following the Conventional Commits and SemVer specifications
https://github.com/apps/standard-release
Apache License 2.0
13 stars 2 forks source link

simply config #3

Closed gr2m closed 6 years ago

gr2m commented 6 years ago

There is a built in method context.config('your-config-file.yml', defaultOptions which will load configuration from the context repository at the path .github/your-config-file.yml: https://probot.github.io/api/latest/Context.html#config

I think you can simplify your code here quite a bit with it

https://github.com/tunnckoCore/semantic-release-app/blob/5e2a40f6d232d6ff514a73ada957b6f15cf6366e/src/lib/config.js#L31-L46

tunnckoCore commented 6 years ago

Oh yea, i thought about it, but just forgot :D Thanks! Fresh view is always a good thing :)