search

standard-things / esm

Tomorrow's ECMAScript modules today!
Other
5.27k stars 146 forks source link

test262 bug: multiple visited star cycle export #544

Closed dnalborczyk closed 6 years ago

dnalborczyk commented 6 years ago

[opening seperate issues for tracking purposes]

Modules can be visited more than once when resolving bindings through
"star" exports as long as the exportName is different each time.

test case: https://github.com/tc39/test262/blob/master/test/language/module-code/instn-iee-star-cycle.js

SyntaxError: Missing export name 'y' in ES module: file:///test262/test/language/module-code/instn-iee-star-cycle-2_FIXTURE.js
      at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
jdalton commented 6 years ago

Thanks @dnalborczyk!

This comes down to a validation glitch on our part. The good news is the y export is being resolved. It's just our check needs adjusting.

Update:

I have this patched locally.

Update:

v3.0.75 is released :tada: