standard-things / esm

Tomorrow's ECMAScript modules today!
Other
5.27k stars 147 forks source link

3.2.23 and 3.2.24 broken #807

Closed steida closed 5 years ago

steida commented 5 years ago

Now sure why yet, but 3.2.22 works.

Investigating...

dnalborczyk commented 5 years ago

hey @steida before you digg too deep, it's likely a duplicate of: https://github.com/standard-things/esm/issues/803 https://github.com/standard-things/esm/issues/804

djMax commented 5 years ago

This is very much still broken, and 803 and 804 claim it as closed.

dnalborczyk commented 5 years ago

@djMax there still seems to be a "leftover" regression regarding computed property names.

djMax commented 5 years ago

I would consider unpublishing 23 and 24.

tomlinton commented 5 years ago

Same experience with broken computed property names.

dnalborczyk commented 5 years ago

@jdalton repro:

export class Foo {
  ["bar"]() {}  // not working
}

marking as "new" bug, since it was mentioned in the other [closed] thread.

gr2m commented 5 years ago

I just run into the same problem, here is my minimal test case: https://github.com/gr2m/esm-bug

// index.js
require = require("esm")(module/*, options*/)

const { MyClass }= require("./module.js")
const mc = new MyClass()
mc[Symbol.iterator]()

// module.js
export class MyClass {
 [Symbol.iterator]() {
   console.log('test')
 }
}
jdalton commented 5 years ago

esm v3.2.25 is released :tada:

gr2m commented 5 years ago

That fixed it for me, cheers 👍

steida commented 5 years ago

Fixed here as well. Thank you!