search

standard-things / esm

Tomorrow's ECMAScript modules today!
Other
5.27k stars 147 forks source link

A Fix to A Breaking Issue is Being Ignored (and Has Been For Months) #893

Open machineghost opened 4 years ago

machineghost commented 4 years ago

First off, let me just say that the esm module is an amazing solution, and I'm so grateful for it.

However, this issue: https://github.com/standard-things/esm/issues/866 has had a working PR submitted for months, for a serious issue which breaks esm for modern JS ... and nothing is happening.

I understand that library maintainers have limited resources, but if you can't even let other people help you solve problems ... I don't know how else to describe that, except as poor project stewardship.

Please consider approving that PR (and more largely, consider what systemic changes might lead to better stewardship, eg. asking for more help from other contributors/maintainers).

omerts commented 3 years ago

Seems like the last commit to this repo was Sep 26, 2019, i don't think this (what used to be amazing) project is maintained anymore.

machineghost commented 3 years ago

Right, and as I said I don't fault any maintainer for not maintaining their project! If someone has been kind enough to share their code with the world, and now they're tired of doing so ... I'm grateful they were kind enough to share it in the first place :)

But to be a responsible citizen of the JS community, the correct thing to do would be to mark the project as dead, or keep it alive and let someone else maintain it. For the "mark it dead" route, all the maintainer has to do is edit their readme.md file to add a big note at the top "This project is dead".

That's it! It takes all of two seconds, and you can do it all in GitHub: you never even need to touch the command line. (But again, a better option would be to post an issue and/or add a note to the readme saying "This project is looking for a new maintainer.")

mk-pmb commented 3 years ago

has had a working PR

Which one are you referring to?

machineghost commented 3 years ago

I'm referring to the one mentioned in the issue itself; literally all you have to do is click the link and the PR is there. In fact, someone in the comments even made a fork of the repo withe the PR in it.

mk-pmb commented 3 years ago

Oh, I'm sorry. Seems I actually misread the issue number above. Nevermind.