search

standard / eslint-config-semistandard

:100: semistandard eslint sharable config
ISC License
64 stars 23 forks source link

Update docs, refactor tests & publishing tweaks #30

Closed vladimyr closed 4 years ago

vladimyr commented 5 years ago

What is the purpose of this pull request? (put an "X" next to item)

What changes did you make? (Give an overview)

  1. Converted actual config from json file to common js module so it can be used to lint test suite which got updated/refactored.
  2. Altered publishing settings to make sure that only necessary files end up in resulting tarball (by adding files field to package.json).
  3. Uptated docs to mention install-peerdeps as easier installation method.
  4. Added .editorconfig.

Is there anything you'd like reviewers to focus on?

This also bumps eslint-config-semistandard peer dep requirement as reported #29

@feross @Flet Is there any reason why I'm removed as a contributor to this repo/package? I understand that ownership has been transferred to @standard organization which I'm not a member of but that situation could be solved politely by either invitation or prior email notice before removing my commit access? Don't get me wrong I'm perfectly fine to continue contributing from outside I'm just voicing my dissatisfaction with how things were handled.

vladimyr commented 4 years ago

/ping @standard

Is anyone out there having some spare time to review & potentially merge this one?

Flet commented 4 years ago

Sorry for the delays. Thanks!

Flet commented 4 years ago

@vladimyr Unsure why you were not invited to the standard org. I've corrected this! Thanks again for helping out!

Flet commented 4 years ago

published as eslint-config-semistandard@15.0.1

feross commented 4 years ago

The change to using semicolons, etc. in this package breaks the tests in standard since this was included in the test suite. I guess it makes sense to follow the semistandard style guide in this package, so I'll just remove this package from the test suite.