standard / eslint-config-standard

ESLint Config for JavaScript Standard Style
https://standardjs.com
MIT License
2.6k stars 565 forks source link

Support eslint-plugin-n 17 #412

Open otto-liljalaakso-nt opened 4 months ago

otto-liljalaakso-nt commented 4 months ago

Here's what I did

I have a project that declares both eslint-config-standard and eslint-plugin-n as dev dependencies. Periodically, I upgrade all dependencies to latest versions I can. Today's attempt produced this:

"devDependencies": {
    "eslint-config-standard": "^17.1.0",
    "eslint-plugin-n": "^17.4.0",
}

What I expected to happen

npm install works and all the linting stuff still works.

What seems to have happened

eslint-config-standard does not support eslint-plugin-n version 17:

$  npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: eslint-config-standard@17.1.0
npm ERR! Found: eslint-plugin-n@17.4.0
npm ERR! node_modules/eslint-plugin-n
npm ERR!   dev eslint-plugin-n@"^17.4.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint-plugin-n@"^15.0.0 || ^16.0.0 " from eslint-config-standard@17.1.0
npm ERR! node_modules/eslint-config-standard
npm ERR!   dev eslint-config-standard@"^17.1.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: eslint-plugin-n@16.6.2
npm ERR! node_modules/eslint-plugin-n
npm ERR!   peer eslint-plugin-n@"^15.0.0 || ^16.0.0 " from eslint-config-standard@17.1.0
npm ERR!   node_modules/eslint-config-standard
npm ERR!     dev eslint-config-standard@"^17.1.0" from the root project
skew202 commented 4 months ago

Similar issue with eslint@9 upgrade

npm ERR! While resolving: @repository
npm ERR! Found: eslint@9.1.1
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^9.1.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^8.0.1" from eslint-config-standard@17.1.0
npm ERR! node_modules/eslint-config-standard
npm ERR!   dev eslint-config-standard@"^17.1.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
mahula commented 3 months ago

We have the same issue upgrading eslint-plugin-n to a 17.x version. There is a renovate update PR.

But it seems since month only the renovate bot is committing on this repo.

mahula commented 3 months ago

Similar issue with eslint@9 upgrade

There is a renovate update PR waiting

amk221 commented 3 months ago

Would love this too please

yoyo837 commented 2 months ago

Similar issue with eslint@9 upgrade

There is a renovate update PR waiting

It just a robot.

CaptainGlac1er commented 2 months ago

It looks like 16 is EOL according to https://www.npmjs.com/package/eslint-plugin-n