standard / standard-engine

:fire_engine: The guts of `standard` modularized for reuse
MIT License
145 stars 39 forks source link

pkg-conf 3.1.0 causes errors. Please upgrade pkg-conf to 4.0.0 #328

Open flyon opened 1 year ago

flyon commented 1 year ago

Here's what I did

I installed rdflib, one of the main packages to work with RDF in JS. This installs solid-namespace, which installs standard, which installs standard-engine@15.1.0, which installs pkg-conf@3.1.0 which installs find-up@3.0.0.

What I expected to happen

Things to work like they did before.

What seems to have happened

find-up@3.0.0 throws an error in recent versions of node.js:

TypeError: The "paths[1]" argument must be of type string. Received type function ([Function (anonymous)])
    at new NodeError (node:internal/errors:405:5)
    at validateString (node:internal/validators:162:11)
    at Object.resolve (node:path:1101:7)
    at /Users/rene/web/coolblock/packages/lincd.org/node_modules/locate-path/index.js:11:49 {

This error has been fixed in more recent find-up versions. And there already is a new version of pkg-conf (4.0.0) which installs the latest find-up (6.0.0).

So my request is to upgrade this package to pkg-conf@4.0.0 and release it as standard-engine 15.1.1, which should fix this kind of downstream error for apps that unknowingly depending on standard-engine and therefor an outdated find-up package.